-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configurable timeout when reading security group rule #3911
Allow configurable timeout when reading security group rule #3911
Conversation
ae7c879
to
ccba8ae
Compare
ccba8ae
to
3c73d02
Compare
3c73d02
to
ad6928c
Compare
ad6928c
to
45d212f
Compare
45d212f
to
e56cd54
Compare
Updated the branch to latest master (conflicts in documentation only) |
e56cd54
to
0a1b81e
Compare
Updated branch on top of latest v1.52.0 release |
@aeschright any chance this gets reviewed and merged please |
@radeksimko could this be reviewed and merged please ? |
@bflad sorry to ask you directly for this but as I saw your work in issues 9345 and 9598 do you think this one could be merged too ? Many thanks in advance |
Terraform team, any chance this can get reviewed soon please ? |
0a1b81e
to
e3fe9e6
Compare
When being throttled on AWS requests, read requests are the first ones to be throttled, and reading security group rules can take longer than 5m to complete. Transform the hard timeout of 5m with a configurable timeout to avoid this problem. Fixes part of hashicorp#3128
e3fe9e6
to
c76c06a
Compare
@bflad @radeksimko @aeschright Is there any specific procedure/alias/... I should follow/write to in order to get this reviewed and potentially merged quite quickly? Many thanks in advance |
Hi folks, I think customizable timeouts are one of the things that require some internal discussion before we can go ahead with them. As you probably noticed, we're working through a pretty big backlog of PRs, and some team members (like me!) are still quite new. Any info you can put on the associated issue #3128 about your use cases and existing workarounds will help us proceed. Thanks for your patience! We really appreciate the contribution. |
@aeschright thanks for your answer and be sure I understand your point here. However there have been other cases like #51677, #3910, #3639 and #3599 (and may be others) that have made their ways into the code. |
Any progress on this one please @aeschright @bflad @ryndaniels ? Thanks |
@aeschright @bflad @ryndaniels have you been able to discuss about this ? |
@aeschright @bflad @ryndaniels any progress on this one please ? |
@aeschright @bflad @ryndaniels any plans to make progress on this one soon please ? |
3 similar comments
@aeschright @bflad @ryndaniels any plans to make progress on this one soon please ? |
@aeschright @bflad @ryndaniels any plans to make progress on this one soon please ? |
@aeschright @bflad @ryndaniels any plans to make progress on this one soon please ? |
@aeschright @bflad @ryndaniels any chance this one gets addressed someday please ? |
@terraformteam anything I can do to have this addressed soon ??? |
Any news on this please ? |
@ewbankkit as you helped me out with lambda & timeout issues some time ago, may be you could pass this one on to people who might be willing to have a look at this please ? Many thanks in advance |
@aeschright @bflad @ryndaniels @ewbankkit any chance this one gets addressed someday please ? |
Any news ? |
Could this be integrated/discussed/adressed somehow ? |
Nothing new ? Can someone tell me how to make progress on this please ? |
@obourdon the additional pings and comments, that do not add additional questions or relevant information to the initial description, do not change our prioritization of an issue or PR, but they do generate a lot of notification noise for us and any others subscribed or participating that slow down our response to items. I understand your frustration with not knowing exactly when something will be delivered or a timeline, especially when its affecting your day to day work. Explaining your need like you did in one of your earlier comments is great and does help us better understand priorities. "+1", "Any news?" type comments though do not further the cause of an issue (reactions do though, as that is one signal we use in prioritization). All that being said, I believe this issue is solved in #9812. |
@paultyng many thanks for pointing this out and sorry for those many updates, however I thought this was a way to prevent the Hashibot from accidentally closing/downgrading the issue/PR due to inactivity and was hoping to at least get feedback or time estimates for feedback (may be I have taken those different habits whe I worked with/for the OpenStack community ;-) ) I agree that looking at the code integrated in #9812 might solve the issue but still does not allow users to configure the timeouts from within their HCL code so may be you could reopen this and potentially integrate it in a next release of the AWS provider. Thanks for your understanding |
@paultyng is there a way to reopen this PR please ? (see comment above) |
Hi @obourdon 👋 If you are still having trouble with version 2.25.0 or later of the Terraform AWS Provider, which includes the fix from #9812 that should negate the need for this type of change, please submit a new GitHub bug report for further discussion about the behavior you are seeing including debug logs. In general, customizable timeouts should not be required for Terraform AWS Provider resources except in cases where operation times are affected by some scalable dimension of the resource itself (e.g. database size affecting the length of time required for |
@bflad thanks for this update. I now understand more your standpoint. We will see if we can reproduce the issue with latest versions of the provider |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
When being throttled on AWS requests, read requests are the first ones
to be throttled, and reading security group rules can take longer than
5m to complete. Transform the hard timeout of 5m with a configurable
timeout to avoid this problem.
Fixes part of #3128